Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cursor jumping #11282

Merged
merged 86 commits into from
Jun 17, 2024
Merged

Fix cursor jumping #11282

merged 86 commits into from
Jun 17, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented May 7, 2024 •
edited
Loading

Draft, because some white space issues. And my "fix" for ## seems to have broken something.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor added 26 commits May 6, 2024 23:20
@koppor
Modernize tests in BibEntryWriterTest
dcb6e31
@koppor
Add tests for current behavior
d75c1a5
@koppor
Improve comments and code
197e723
@koppor
Re-order tests
0331c2e
@koppor
Extract method
42faa91
@koppor
Fix handling of ##
6594317
@koppor
Fix detection of multiline fields
05d9cbf
@koppor
Fix space removal
60efa87
@koppor
Fix trimming of content
1b62eb3
@koppor
Codestyle: Tests
548bec4
@koppor
Remove standard cleanups
e32f712
@koppor
Add CHANGELOG.md entry
8b7dc30
@koppor
Right trim multiline fields
06805f7
@koppor
Add links to CHANGELOG.md
5f2dde2
@koppor
Merge remote-tracking branch 'upstream/main' into fix-5904
ab6e5fd
@koppor
Test case cleanup
e901b32
@koppor
Fix whitespace formatting
2f2d256
@koppor
Reformat comment (and add TODO marker)
febbcc8
@koppor
More whitespace tweaking
09f7c80
@koppor
Merge branch 'main' into fix-5904
1a1a8e6
@koppor
Use our builder if possible
2a6da5e
@koppor
Fix whitespace at import
49adca5
@koppor
Merge remote-tracking branch 'origin/main' into fix-5904
f03a172
@koppor
Try to get gradle executing all tests on GitHub CI
94afc94
@koppor
Tweak parallel tests
18b41ea
@koppor
Optimize build
185698a
@koppor
Copy link
Member Author

koppor commented Jun 4, 2024

I don't know about the discrepancy about local and remote test execution

  • CI: FAILURE: Executed 8661 tests in 4m 28s (3 failed, 29 skipped)
  • local: FAILURE: Executed 8661 tests completed, 51 failed, 16 skipped

@koppor koppor mentioned this pull request Jun 4, 2024
Merged
6 tasks
@koppor koppor marked this pull request as ready for review June 17, 2024 12:36
@koppor koppor mentioned this pull request Jun 17, 2024
Closed
@koppor koppor enabled auto-merge June 17, 2024 12:47
This was referenced Jun 17, 2024
Closed
Closed
@koppor koppor added this pull request to the merge queue Jun 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit d51b52b Jun 17, 2024
25 of 26 checks passed
@koppor koppor deleted the fix-5904 branch June 17, 2024 20:26
@LoayGhreeb
Copy link
Collaborator

@koppor, an exception is thrown when trying to use Ctrl+Z on any text field in the entry editor.

2024-06-19 06:13:03 [JavaFX Application Thread] org.jabref.gui.FallbackExceptionHandler.uncaughtException()
ERROR: Uncaught exception occurred in Thread[#54,JavaFX Application Thread,5,main]: java.lang.NullPointerException: Cannot read field "next" because "this.undoChange" is null
	at [email protected]/javafx.scene.control.TextInputControl.updateUndoRedoState(TextInputControl.java:1250)
	at [email protected]/javafx.scene.control.TextInputControl.undo(TextInputControl.java:1201)
	at [email protected]/com.sun.javafx.scene.control.behavior.TextInputControlBehavior.undo(TextInputControlBehavior.java:553)
	at [email protected]/com.sun.javafx.scene.control.behavior.TextInputControlBehavior.lambda$new$30(TextInputControlBehavior.java:180)
	at [email protected]/com.sun.javafx.scene.control.behavior.TextInputControlBehavior.lambda$keyMapping$62(TextInputControlBehavior.java:344)
	at [email protected]/com.sun.javafx.scene.control.inputmap.InputMap.handle(InputMap.java:274)
	at [email protected]/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)
	at [email protected]/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:232)
	at [email protected]/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:189)
	at [email protected]/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at [email protected]/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
	at [email protected]/com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54)
	at [email protected]/javafx.event.Event.fireEvent(Event.java:198)
	at [email protected]/javafx.scene.Scene.processKeyEvent(Scene.java:2195)
	at [email protected]/javafx.scene.Scene$ScenePeerListener.keyEvent(Scene.java:2716)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(GlassViewEventHandler.java:218)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(GlassViewEventHandler.java:150)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleKeyEvent$1(GlassViewEventHandler.java:250)
	at [email protected]/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:430)
	at [email protected]/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleKeyEvent(GlassViewEventHandler.java:249)
	at [email protected]/com.sun.glass.ui.View.handleKeyEvent(View.java:542)
	at [email protected]/com.sun.glass.ui.View.notifyKey(View.java:966)
	at [email protected]/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
	at [email protected]/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:184)
	at java.base/java.lang.Thread.run(Thread.java:1583)

@koppor koppor mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When saving: The libary has been modified by another program Cursors jumps to the beginning
4 participants
@koppor @LoayGhreeb @Siedlerchr @calixtus